Make AzureSQL KeyVault secret deletion best effort (#1412)

- It already was best effort in most places but we missed one.
Azure · Apr 20, 2021 · 0c94d5a · 0c94d5a
1 parent 061cb3a
commit 0c94d5a
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/pkg/resourcemanager/azuresql/azuresqluser/azuresqluser_reconcile.go b/pkg/resourcemanager/azuresql/azuresqluser/azuresqluser_reconcile.go
@@ -251,13 +251,11 @@ func (s *AzureSqlUserManager) Ensure(ctx context.Context, obj runtime.Object, op
 			}
 		}
 
-		err = userSecretClient.Delete(
+		// Purposefully ignoring error here for now
+		userSecretClient.Delete(
 			ctx,
 			userSecretKey,
 			secrets.Flatten(true, toDelete...))
-		if err != nil {
-			return false, err
-		}
 
 		err = userSecretClient.Upsert(
 			ctx,