Skip to content

Commit

Permalink
PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
matthchr committed Jun 26, 2020
1 parent 33e8d06 commit 185fb9b
Showing 1 changed file with 0 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -122,19 +122,6 @@ func (s *AzureSqlServerManager) Ensure(ctx context.Context, obj runtime.Object,
if instance.Status.Provisioning ||
(!specHashWasEmpty && instance.Status.SpecHash == hash) {

// TODO: This is a bit of a hack because really this check should be in the SDK.
// TODO: See: https://github.com/Azure/azure-sdk-for-go/issues/10712
// Note that this can really only happen due to bad state in etcd because the
// CRD for the resource requires this field. Bad state in etcd can be caused by
// something like conversion webhooks being disabled and using a non-storage
// version of the CRD. This is really just a nice-to-have error to make it clear
// what the problem is for that rare case, which primarily can happen while
// we are testing locally.
if instance.Spec.ResourceGroup == "" {
instance.Status.Message = "A non-empty resource group must be specified."
return false, nil
}

serv, err := s.GetServer(ctx, instance.Spec.ResourceGroup, instance.Name)
if err != nil {
azerr := errhelp.NewAzureErrorAzureError(err)
Expand Down

0 comments on commit 185fb9b

Please sign in to comment.