Merge pull request #1025 from jananivMS/sqlservercrash

Fix nil pointer dereference in Sql Server operator

pkg/resourcemanager/azuresql/azuresqlserver/azuresqlserver_reconcile.go

@@ -54,22 +54,24 @@ func (s *AzureSqlServerManager) Ensure(ctx context.Context, obj runtime.Object,
 		}
 
 		// Assure that the requested name is available and assume the secret exists
-		checkNameResult, _ := CheckNameAvailability(ctx, instance.Name)
-		if *checkNameResult.Available != true {
-			instance.Status.Provisioning = false
-			if _, err := s.GetServer(ctx, instance.Spec.ResourceGroup, instance.Name); err != nil {
-				instance.Status.Message = "SQL server already exists somewhere else"
-				return true, nil
-			}
+		checkNameResult, err := CheckNameAvailability(ctx, instance.Name)
+		if err == nil {
+			if *checkNameResult.Available != true {
+				instance.Status.Provisioning = false
+				if _, err := s.GetServer(ctx, instance.Spec.ResourceGroup, instance.Name); err != nil {
+					instance.Status.Message = "SQL server already exists somewhere else"
+					return true, nil
+				}
 
-			instance.Status.Message = fmt.Sprintf(
-				`SQL server already exists and the credentials could not be found. 
+				instance.Status.Message = fmt.Sprintf(
+					`SQL server already exists and the credentials could not be found. 
 				If using kube secrets a secret should exist at '%s' for keyvault it should be '%s'`,
-				key.String(),
-				fmt.Sprintf("%s-%s", key.Namespace, key.Name),
-			)
+					key.String(),
+					fmt.Sprintf("%s-%s", key.Namespace, key.Name),
+				)
 
-			return false, nil
+				return false, nil
+			}
 		}
 
 		secret, err = NewSecret(instance.Name)