Skip to content

Commit

Permalink
Use Codecov (#345)
Browse files Browse the repository at this point in the history
Coveralls seems to keep having issues where only one of the reports is applied, giving results like "-77% code coverage". Let's see if Codecov is better.
  • Loading branch information
Porges authored Dec 18, 2020
1 parent 6842fcf commit 4b67cd3
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 42 deletions.
23 changes: 2 additions & 21 deletions .github/workflows/master-validation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,24 +29,5 @@ jobs:
AZURE_CLIENT_SECRET: ${{ secrets.AZURE_CLIENT_SECRET }}
AZURE_SUBSCRIPTION_ID: ${{ secrets.AZURE_SUBSCRIPTION_ID }}

- name: Upload generator coverage to coveralls
uses: coverallsapp/github-action@master
with:
github-token: ${{ secrets.github_token }}
path-to-lcov: ./hack/generator/coverage.lcov
flag-name: pr-generator-${{ runner.os }}
parallel: true

- name: Upload generated integration coverage to coveralls
uses: coverallsapp/github-action@master
with:
github-token: ${{ secrets.github_token }}
path-to-lcov: ./hack/generated/coverage-integration-envtest.lcov
flag-name: pr-generated-integration-${{ runner.os }}
parallel: true

- name: Coveralls done
uses: coverallsapp/github-action@master
with:
github-token: ${{ secrets.github_token }}
parallel-finished: true
- name: Upload code coverage to Codecov
run: bash <(curl -s https://codecov.io/bash)
23 changes: 2 additions & 21 deletions .github/workflows/pr-validation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,24 +19,5 @@ jobs:
- name: Run CI tasks
run: docker run -w /workspace -v $GITHUB_WORKSPACE:/workspace -e AZURE_TENANT_ID -e AZURE_CLIENT_ID -e AZURE_CLIENT_SECRET -e AZURE_SUBSCRIPTION_ID devcontainer:1.0 task ci

- name: Upload generator coverage to coveralls
uses: coverallsapp/github-action@master
with:
github-token: ${{ secrets.github_token }}
path-to-lcov: ./hack/generator/coverage.lcov
flag-name: pr-generator-${{ runner.os }}
parallel: true

- name: Upload generated integration coverage to coveralls
uses: coverallsapp/github-action@master
with:
github-token: ${{ secrets.github_token }}
path-to-lcov: ./hack/generated/coverage-integration-envtest.lcov
flag-name: pr-generated-integration-${{ runner.os }}
parallel: true

- name: Coveralls done
uses: coverallsapp/github-action@master
with:
github-token: ${{ secrets.github_token }}
parallel-finished: true
- name: Upload code coverage to Codecov
run: bash <(curl -s https://codecov.io/bash)

0 comments on commit 4b67cd3

Please sign in to comment.