Skip to content

Commit

Permalink
Relax enum restrictions on Storage bypass parameter (#4328)
Browse files Browse the repository at this point in the history
Fixes #4247.

Storage supports passing multiple values to the Bypass parameter
separated by a comma, but that's not how Swagger enums work so the fact
they've specified this field as an enum is technically incorrect. We
just treat it as a string to allow the user to pass multiple values
  • Loading branch information
matthchr authored Oct 9, 2024
1 parent fee7fed commit 67a21e7
Show file tree
Hide file tree
Showing 20 changed files with 45 additions and 239 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

43 changes: 5 additions & 38 deletions v2/api/storage/v1api20210401/storage_account_types_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 2 additions & 10 deletions v2/api/storage/v1api20210401/structure.txt
Original file line number Diff line number Diff line change
Expand Up @@ -99,11 +99,7 @@ StorageAccount: Resource
│ │ ├── "TLS1_1"
│ │ └── "TLS1_2"
│ ├── NetworkAcls: *Object (5 properties)
│ │ ├── Bypass: *Enum (4 values)
│ │ │ ├── "AzureServices"
│ │ │ ├── "Logging"
│ │ │ ├── "Metrics"
│ │ │ └── "None"
│ │ ├── Bypass: *string
│ │ ├── DefaultAction: *Enum (2 values)
│ │ │ ├── "Allow"
│ │ │ └── "Deny"
Expand Down Expand Up @@ -721,11 +717,7 @@ StorageAccount_Spec_ARM: Object (8 properties)
│ │ ├── "TLS1_1"
│ │ └── "TLS1_2"
│ ├── NetworkAcls: *Object (5 properties)
│ │ ├── Bypass: *Enum (4 values)
│ │ │ ├── "AzureServices"
│ │ │ ├── "Logging"
│ │ │ ├── "Metrics"
│ │ │ └── "None"
│ │ ├── Bypass: *string
│ │ ├── DefaultAction: *Enum (2 values)
│ │ │ ├── "Allow"
│ │ │ └── "Deny"
Expand Down
4 changes: 2 additions & 2 deletions v2/api/storage/v1api20210401/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

43 changes: 5 additions & 38 deletions v2/api/storage/v1api20220901/storage_account_types_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 2 additions & 10 deletions v2/api/storage/v1api20220901/structure.txt
Original file line number Diff line number Diff line change
Expand Up @@ -125,11 +125,7 @@ StorageAccount: Resource
│ │ ├── "TLS1_1"
│ │ └── "TLS1_2"
│ ├── NetworkAcls: *Object (5 properties)
│ │ ├── Bypass: *Enum (4 values)
│ │ │ ├── "AzureServices"
│ │ │ ├── "Logging"
│ │ │ ├── "Metrics"
│ │ │ └── "None"
│ │ ├── Bypass: *string
│ │ ├── DefaultAction: *Enum (2 values)
│ │ │ ├── "Allow"
│ │ │ └── "Deny"
Expand Down Expand Up @@ -862,11 +858,7 @@ StorageAccount_Spec_ARM: Object (8 properties)
│ │ ├── "TLS1_1"
│ │ └── "TLS1_2"
│ ├── NetworkAcls: *Object (5 properties)
│ │ ├── Bypass: *Enum (4 values)
│ │ │ ├── "AzureServices"
│ │ │ ├── "Logging"
│ │ │ ├── "Metrics"
│ │ │ └── "None"
│ │ ├── Bypass: *string
│ │ ├── DefaultAction: *Enum (2 values)
│ │ │ ├── "Allow"
│ │ │ └── "Deny"
Expand Down
4 changes: 2 additions & 2 deletions v2/api/storage/v1api20220901/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 67a21e7

Please sign in to comment.