Skip to content

Commit

Permalink
Continue reconciling Azure SQL managed users for unknown errors (#1336)
Browse files Browse the repository at this point in the history
These could be setup issues like the AAD admin not being set on the
server - giving up immediately means the only way to get the user
created successfully is to edit the resource to remove the finalizer,
delete it, then re-add. The reconcile loop for regular users doesn't
use this pattern of returning true, nil when it can't reach the server.
  • Loading branch information
babbageclunk authored Jan 7, 2021
1 parent ed450fc commit b311032
Showing 1 changed file with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,8 @@ func (s *AzureSqlManagedUserManager) Ensure(ctx context.Context, obj runtime.Obj
return false, nil
}

// Other failures are terminal
instance.Status.SetFailedProvisioning(instance.Status.Message)
return true, nil
return false, nil
}

userExists, err := s.UserExists(ctx, db, requestedUsername)
Expand Down

0 comments on commit b311032

Please sign in to comment.