Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using wrong owner type doesn't give a helpful message #1455

Closed
Porges opened this issue Nov 10, 2020 · 3 comments · Fixed by #1747
Closed

Using wrong owner type doesn't give a helpful message #1455

Porges opened this issue Nov 10, 2020 · 3 comments · Fixed by #1747
Assignees

Comments

@Porges
Copy link
Member

Porges commented Nov 10, 2020

Using the wrong type for the Owner property only results in missing-owner messages, since the lookup for the owner name happens against the exact GKV of the type of that property. We could at least state the type it is looking for in the error. Bonus points would be if we fail a bunch of times we scan the whole namespace for something with the same name and report that you are using the wrong owner type!

@Porges Porges transferred this issue from Azure/k8s-infra May 14, 2021
@Porges Porges added this to the codegen-beta milestone May 17, 2021
@matthchr
Copy link
Member

matthchr commented Aug 6, 2021

Moving this to alpha-1 as it seems easy to do and should have a high impact on helping users diagnose where they've made a mistake.

We can triage it back out of alpha-1 later if it ends up not getting done.

@matthchr matthchr modified the milestones: codegen-beta, codegen-alpha-1 Aug 6, 2021
@matthchr
Copy link
Member

So what we have right now is:

NAME           READY   REASON            MESSAGE
samplesubnet   False   WaitingForOwner   The owner of this resource cannot be found in Kubernetes. Process is blocked until the owner is created.

@matthchr
Copy link
Member

I've changed it to this:

samplesubnet   False   WaitingForOwner   Owner "default/aso-sample-rg, GroupKind: microsoft.network.azure.com/VirtualNetwork" cannot be found. Progress is blocked until the owner is created.

Will send a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants