Improve owner missing error message #1747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthchr
requested review from
davefellows,
Porges and
theunrepentantgeek
as code owners
matthchr
force-pushed
the
feature/owner-error
branch
from
5e797df
to
1f11e47
Compare
Codecov Report
@@ Coverage Diff @@
## master #1747 +/- ##
=======================================
Coverage 42.11% 42.11%
=======================================
Files 309 309
Lines 89877 89877
=======================================
Hits 37851 37851
Misses 48699 48699
Partials 3327 3327
Continue to review full report at Codecov.
|
matthchr
force-pushed
the
feature/owner-error
branch
from
e6d0bf2
to
821b511
Compare
matthchr
force-pushed
the
feature/owner-error
branch
from
821b511
to
5cec45a
Compare
|
Looks much nicer! |
| return b.builder.MakeFalseCondition( | ||
| ConditionTypeReady, | ||
| ConditionSeverityWarning, | ||
| ReasonWaitingForOwner, | ||
| "The owner of this resource cannot be found in Kubernetes. Process is blocked until the owner is created.") | ||
| fmt.Sprintf("Owner %q cannot be found. Progress is blocked until the owner is created.", ownerDetails)) |
There was a problem hiding this comment.
👍 for actually naming the thing that can't be found.
theunrepentantgeek
approved these changes
Aug 27, 2021
Porges
reviewed
Aug 27, 2021
Porges
approved these changes
Aug 27, 2021
Co-authored-by: George Pollard <porges@porg.es>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1455
What this PR does / why we need it:
Improves the message when the owner is missing or wrong. It now reads:
This still isn't perfect because it doesn't explicitly say: "You gave us something that points to the wrong type", but that's actually pretty hard to do because Kubernetes allows multiple resources (of different
Kind's) to have the same name, so it could be a coincidence that the owner they're looking for just so happens to have the same name as some other resource in the cluster in that same namespace.I think this message should be pretty clear still though as we list the specific type we're looking for in addition to namespace/name, so they should be able to easily
kubectl get <kind> -n <namespace>and realize the resource we're looking for isn't there.