Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate generic controller into existing ASO release #1514

Closed
3 tasks
matthchr opened this issue May 26, 2021 · 1 comment
Closed
3 tasks

Integrate generic controller into existing ASO release #1514

matthchr opened this issue May 26, 2021 · 1 comment
Milestone
codegen-alpha-6

Comments

@matthchr
Copy link
Member

  • Publish generic controller container image to MCR alongside handcrafted ASO container image as part of master build.
    • Possibly use this as an opportunity to clean up existing ASO makefile.
  • Include generated controller and generated CRDs alongside ASO CRDs in release (and Helm).
    • Open question if they share the same resource suffix or not.
  • Determine what to do for "overlapping" resources that are both generated and handcrafted (ResourceGroup comes to mind as the first)
@matthchr matthchr added the task label May 26, 2021
@matthchr matthchr added this to the codegen-alpha-0 milestone May 26, 2021
@Porges Porges mentioned this issue May 27, 2021
Merged
Porges added a commit that referenced this issue May 30, 2021
@Porges
Add v2 controller:docker-build output, rename binaries &c (#1521)
aa3d6f2 
Adds a Taskfile target for building a docker image containing the `k8sinfra-controller`, and renames it to the `aso-controller`.

Sub-tasks:
* add [docker-from-docker](https://github.com/microsoft/vscode-dev-containers/tree/main/containers/docker-from-docker) support to the devcontainer
* rename generator to `aso-gen`
* update various test names to `aso`, and _most_ other names as well
    * I haven’t update the codegen header as that will churn tonnes of files, and will do that as a separate PR
* move over “documentation issues” that are referred to in comments into the `azure-service-operator` repo (PRs cannot be moved)

**How does this PR make you feel**:
![gif](https://media.giphy.com/media/3o6Mbfal2sHCGhZEHe/giphy.gif)

Ref: #1514
@matthchr
Copy link
Member Author

We've decided that we're not going to give a single release that includes both. They will have separate Helm charts/OperatorHub bundle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
codegen-alpha-6
Development

No branches or pull requests
2 participants
@theunrepentantgeek @matthchr