Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubebuilder:printcolumn directives to generated resources #1665

Closed
babbageclunk opened this issue Jul 27, 2021 · 0 comments · Fixed by #1699
Closed

Add kubebuilder:printcolumn directives to generated resources #1665

babbageclunk opened this issue Jul 27, 2021 · 0 comments · Fixed by #1699
Assignees

Comments

@babbageclunk
Copy link
Member

Describe the current behavior
At the moment generated resources don't indicate their provisioning state in tabular kubectl output, so you need to keep checking the yaml output to find out whether they're ready.

Describe the improvement
Adding kubebuilder:printcolumn comments to the generated code would make them much nicer to use:

// +kubebuilder:printcolumn:name="ProvisioningState",type="string",JSONPath=".status.provisioningState"

(Although the name ProvisioningState's probably a bit long.)

At the moment there's not really an equivalent of the message field on the ASOv1 resources - once the condition work spec'd in #1614 is done it would make sense to use the status and message fields from the ready condition (presumably these will supplant the status.provisioningState).

@babbageclunk babbageclunk added this to the codegen-alpha-2 milestone Jul 27, 2021
@matthchr matthchr self-assigned this Aug 7, 2021
matthchr added a commit to matthchr/azure-service-operator that referenced this issue Aug 9, 2021
matthchr added a commit to matthchr/azure-service-operator that referenced this issue Aug 9, 2021
matthchr added a commit to matthchr/azure-service-operator that referenced this issue Aug 10, 2021
matthchr added a commit to matthchr/azure-service-operator that referenced this issue Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants