Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 2023-02-02-preview API version of AKS before June 20th 2024 #3981

Closed
matthchr opened this issue Apr 30, 2024 · 2 comments · Fixed by #4182
Closed

Remove 2023-02-02-preview API version of AKS before June 20th 2024 #3981

matthchr opened this issue Apr 30, 2024 · 2 comments · Fixed by #4182
Assignees
@matthchr
Labels
breaking A change which likely be breaking
Milestone
v2.9.0

Comments

@matthchr
Copy link
Member

Need to document this as an upcoming breaking change too.
@matthchr matthchr added the breaking A change which likely be breaking label Apr 30, 2024
@matthchr matthchr added this to the v2.8.0 milestone Apr 30, 2024
@matthchr matthchr self-assigned this Jun 6, 2024
@matthchr matthchr mentioned this issue Jun 12, 2024
Closed
@matthchr
Copy link
Member Author

I realized we can't actually do this in 2.8.0 because we first need to ship #4086 to allow conversion between 2023-02-02-preview TrustedAccessRoleBindings and 2024-04-02-preview TrustedAccessRoleBindings.

Also since that resource only exists in preview that preview version could be a storage version so we'll need to update asoctl to remove it too.

I don't see much usage of TrustedAccessRoleBinding so it's unlikely many users are impacted, but still we should be careful here.

Kicking this out to 2.9.0 so that there's 1 ASO version where TrustedAccessRoleBinding has a newer API version to convert to.

@matthchr matthchr modified the milestones: v2.8.0, v2.9.0 Jun 13, 2024
@matthchr
Copy link
Member Author

matthchr commented Jul 1, 2024

I have this done locally

matthchr added a commit to matthchr/azure-service-operator that referenced this issue Aug 7, 2024
@matthchr
Delete AKS preview API version 2023-02-02-preview
136064e 
Closes Azure#3981
matthchr added a commit to matthchr/azure-service-operator that referenced this issue Aug 7, 2024
@matthchr
Delete AKS preview API version 2023-02-02-preview
26161cd 
Closes Azure#3981
@matthchr matthchr mentioned this issue Aug 7, 2024
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Aug 8, 2024
@matthchr
Delete AKS preview API version 2023-02-02-preview (#4182)
51616af 
Closes #3981
@github-project-automation github-project-automation bot moved this from Backlog to Recently Completed in Azure Service Operator Roadmap Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthchr matthchr

Labels
breaking A change which likely be breaking
Projects
Azure Service Operator Roadmap
Archived in project
Milestone
v2.9.0
Development

Successfully merging a pull request may close this issue.

Delete AKS preview API version 2023-02-02-preview matthchr/azure-service-operator
2 participants
@theunrepentantgeek @matthchr