Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: asoctl doesn't support clouds except public #4032

Closed
matthchr opened this issue May 23, 2024 · 0 comments · Fixed by #4033
Closed

Bug: asoctl doesn't support clouds except public #4032

matthchr opened this issue May 23, 2024 · 0 comments · Fixed by #4033
Assignees
@matthchr
Labels
bug 🪲 Something isn't working
Milestone
v2.8.0

Comments

@matthchr
Copy link
Member

Describe the bug
We don't support nonpublic clouds in asoctl, even though we do in ASO:
https://github.com/Azure/azure-service-operator/blob/main/v2/cmd/asoctl/cmd/import_azure_resource.go#L76C2-L76C37

Expected behavior
nonpublic clouds are supported
@matthchr matthchr added this to the v2.8.0 milestone May 23, 2024
@matthchr matthchr added the bug 🪲 Something isn't working label May 23, 2024
@matthchr matthchr self-assigned this May 23, 2024
matthchr added a commit to matthchr/azure-service-operator that referenced this issue May 23, 2024
@matthchr
Support multiple clouds in asoctl
853a8ac 
This fixes Azure#4032.

Also improve the asoctl documentation
@matthchr matthchr mentioned this issue May 23, 2024
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this issue May 24, 2024
@matthchr
Support multiple clouds in asoctl (#4033)
2f89d6c 
This fixes #4032.

Also improve the asoctl documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthchr matthchr

Labels
bug 🪲 Something isn't working
Projects
Azure Service Operator Roadmap
Archived in project
Milestone
v2.8.0
Development

Successfully merging a pull request may close this issue.

Support multiple clouds in asoctl matthchr/azure-service-operator
2 participants
@theunrepentantgeek @matthchr