Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Separate resource client into individual managers per sql operators #475

Closed
5 tasks
melonrush13 opened this issue Nov 15, 2019 · 0 comments · Fixed by #940
Closed
5 tasks

Task: Separate resource client into individual managers per sql operators #475

melonrush13 opened this issue Nov 15, 2019 · 0 comments · Fixed by #940
Assignees
Labels
high-priority Issues we intend to prioritize (security, outage, blocking bug)

Comments

@melonrush13
Copy link
Contributor

melonrush13 commented Nov 15, 2019

We want to separated the sqlclient/resourceclient into 5 operator managers (1 manager per sql operator w/ individual tests) to have a more consistent, clean code base for when we update the sql controller to the generic controller.

Pre task work for ticket #451

Done Criteria
The following resources should have their own managers, go file, and test files inside the sql resourcemanager, as well as test files for each mocked manager.

  • SqlServerManager
  • SqlDBManager
  • SqlFirewallManager
  • SqlFailoverGroup
  • SqlUser

User Story Reference
#7

@melonrush13 melonrush13 added the bug 🪲 Something isn't working label Nov 15, 2019
@melonrush13 melonrush13 self-assigned this Nov 15, 2019
@melonrush13 melonrush13 added task high-priority Issues we intend to prioritize (security, outage, blocking bug) and removed bug 🪲 Something isn't working labels Nov 15, 2019
@melonrush13 melonrush13 assigned ajamess and jakiefermsft and unassigned ajamess Dec 2, 2019
@buhongw7583c buhongw7583c mentioned this issue Apr 14, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high-priority Issues we intend to prioritize (security, outage, blocking bug)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants