Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task: Update the Sql server controller to generic controller model #451

Closed
2 tasks
jananivMS opened this issue Nov 6, 2019 · 1 comment
Closed
2 tasks

Task: Update the Sql server controller to generic controller model #451

jananivMS opened this issue Nov 6, 2019 · 1 comment
Assignees
@frodopwns

Comments

@jananivMS
Copy link
Contributor

jananivMS commented Nov 6, 2019 •
edited by melonrush13
Loading

Move the Sql server controller logic to use the generic controller model

Following the same pattern as #393

**Done criteria **
This is the "done" criteria for this task

  • SQL server operator uses the generic controller and reconciler interface
  • SQL server controller uses one reconcile loop

User story reference*

#7
@melonrush13 melonrush13 self-assigned this Nov 25, 2019
@melonrush13 melonrush13 mentioned this issue Dec 2, 2019
Closed
5 tasks
@frodopwns frodopwns mentioned this issue Dec 3, 2019
Closed
@frodopwns frodopwns self-assigned this Feb 12, 2020
@jananivMS
Copy link
Contributor Author

Fixed with PR #632

Porges pushed a commit that referenced this issue May 11, 2021
@babbageclunk
Turn on shadow-checking in golangci-lint configuration (#451)
5073677 
* Turn on shadowing checking in golangci-lint config

* Fix shadowing warnings in generator code

* Fix shadowing warnings in controller code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frodopwns frodopwns

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@frodopwns @melonrush13 @jananivMS @jakiefermsft