Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/Bug: Implement label function for KeyVault tags to ignore bad character label #828

Closed
melonrush13 opened this issue Mar 26, 2020 · 0 comments · Fixed by #888
Closed
Assignees
Labels
bug 🪲 Something isn't working

Comments

@melonrush13
Copy link
Contributor

Some characters allowed in Kube labels are not allowed in Azure tags.
Bad Characters:
<, >, %, , /, ?

We want to use the function in helpers/labels (from #814) to ignore the above bad characters.
We want to return the rest of the labels in the format expected by Azure for tag, and ignore the ones which are 'invalid'.

Done criteria

  • Labels Function is implemented in KeyVault
  • User is able to create a KeyVault with an improper label, and it still successfully provisions without the invalid tag.

User story reference

#

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants