filter bad characters from label keys when creating tags list #814
Conversation
|
Should we create another ticket to add this to the rest of the controllers which use tags? |
|
Want to make sure I am understanding the expected performance correctly for issue #805 |
pkg/helpers/labels.go
Outdated
| issues := [][]string{} | ||
| for k, v := range in { | ||
| if strings.ContainsAny(k, "<>%/?\\") { | ||
| issues = append(issues, []string{k, "contains a character not allowed in Azure tags"}) |
There was a problem hiding this comment.
Right now the user never sees "contains a character not allowed in Azure tags". Is that okay? Do we want to "log" this somewhere? I only see this message from Kubernetes The AzureSqlServer "sqlserver-sample-777-meltwo" is invalid: metadata.labels: Invalid value: "value/one": a valid label must be an empty string or consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue', or 'my_value', or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?')) Which is how it performs on master too
There was a problem hiding this comment.
some characters even Kube won't let you put in labels :-)
try something like "example.com/test": "yay"
I added the issues for when we decide what (if anything) to do with them. Right now they are ignored.
There was a problem hiding this comment.
:) I see. That makes a lot mores sense! Thanks!
yeah, that is probably a good idea |
if characters that Azure won't accept in tag keys exist in a certain label it just won't be used. We can talk about whether to log it or what. |
Ok! Thanks for clarifying. Right now, when I make a sqlserver with 1 valid tag and 1 invalid tag it does not currently create at all. I get the error message on creation, and then when i do an -o yaml on that name, it says "not found". |
pkg/helpers/labels.go
Outdated
| newK := k | ||
| value := v | ||
| if strings.ContainsAny(k, "<>%/?\\") { | ||
| newK = ReplaceAny(k, []string{"<", ">", "%", "/", "\\\\"}) |
There was a problem hiding this comment.
| newK = ReplaceAny(k, []string{"<", ">", "%", "/", "\\\\"}) | |
| newK = ReplaceAny(k, []string{"<", ">", "%", "/", "?", "\\\\"}) |
closes #805
What this PR does / why we need it:
Azure doesn't allow some characters in tag keys that Kube allows in label keys. This PR
creates a function that filters the disallowed characters and returns the rest of the labels in the format expected by Azure for tags.
This PR also implements the function in the Azure SQL Server controller.