Task: Remove functions used in errhelp.go across controllers #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpflueger
reviewed
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #628
closes #1032
We are using functions from errhelp.go such as IsStatusCode204, and IsStatusCode404. We want to remove these function calls used throughout the controllers and have them use errors.go string checks instead (such as ParentNotFoundErrorCode) to be consistent across controllers.
In Addition, we would also like to ideally error check from HTTP status codes instead of strings.
Done criteria
Remove string functions and instead error check them from errors.go
Fix in the following controllers..
Also, fixes MySql delete issue