Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline work #1053

Merged
merged 319 commits into from
May 15, 2020
Merged

Pipeline work #1053

merged 319 commits into from
May 15, 2020

Conversation

jananivMS
Copy link
Contributor

@jananivMS jananivMS commented May 14, 2020

Closes #612
Closes #937
Closes #949
Closes #957
Closes #938

What this PR does / why we need it:

Builds on top of Jarrod's and Denis's pipeline work. This also adds/modifies the following:

  1. Adds back the running of tests on a Kind cluster to keep the current reliability and to keep the ability to run parallel runs which is critical.
    Changed back the runs to not tee to a file for report as this removes our ability to track test runs in progress. Kept the coverage report intact.
  2. Removes the added docker file as it doesn't add much and the existing dockerfile is multi stage which helps keep the final image size small.
  3. Helm deploy was missing steps to correctly package the chart. Fixed those.
  4. Helm deploy now deploys to the cluster to the specified namespace (still need to fix being able to deploy to multiple namespace in the same cluster without running into issues due to some prereqs existing)
  5. Deploy to AKS now uses managed identity
  6. Added back the steps that were removed to package the artifacts, image for builds on the master branch. The release pipeline depends on this.
  7. Also added the Helm tar file as part of the artifacts so we can package that in the release drop.

Special notes for your reviewer:

How does this PR make you feel:
gif

If applicable:

  • this PR contains documentation
  • this PR contains tests

@jananivMS jananivMS changed the title [DO not review yet] Pipeline work Pipeline work May 14, 2020
@jananivMS jananivMS requested a review from dkisselev May 14, 2020 17:42
Makefile.legacy Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
dkisselev
dkisselev previously approved these changes May 15, 2020
Copy link
Contributor

@dkisselev dkisselev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall changes look good to me

@jananivMS
Copy link
Contributor Author

@dkisselev Denis - addressed your comments, need a re-review

Copy link
Contributor

@dkisselev dkisselev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Only note is that the tests in this pipeline fail in Jarrod's azdo because the APIM namespace doesn't exist there - the issue will re-present itself as soon as we move to switch over so it will be a quick fix to update the tests then.

@jananivMS jananivMS merged commit d770cb6 into Azure:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants