Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmosdb Secret connection string #1077

Merged
merged 5 commits into from
May 19, 2020
Merged

Cosmosdb Secret connection string #1077

merged 5 commits into from
May 19, 2020

Conversation

jpflueger
Copy link
Contributor

@jpflueger jpflueger commented May 18, 2020

Closes #1057

What this PR does / why we need it:

  • Adds CosmosDB docs
  • Adds connection string to the CosmosDB Secret

Special notes for your reviewer:

  1. Create a new CosmosDB resource
  2. Validate that the secret for the resource contains secret values for:
  • primary<API-Type>ConnectionString
  • secondary<API-Type>ConnectionString
  • primaryReadOnly<API-Type>ConnectionString
  • secondaryReadOnly<API-Type>ConnectionString

How does this PR make you feel:
gif

If applicable:

  • this PR contains documentation
  • this PR contains tests

Copy link
Contributor

@frodopwns frodopwns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jpflueger jpflueger merged commit 0f37fe8 into Azure:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants