Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add health check to controller manager #1088

Merged
merged 1 commit into from
May 20, 2020

Conversation

buhongw7583c
Copy link
Contributor

Closes #1036

What this PR does / why we need it:
Add a healthy check in controller manager to ensure the connection to Azure is healthy.

Special notes for your reviewer:
This is indeed the same pull request as #1041. Due to the repo sync issue, has to create a new repo and made the new pull request. Comments could be found from the old link though.

How does this PR make you feel:
gif

If applicable:

  • this PR contains documentation
  • this PR contains tests

Copy link
Contributor

@frodopwns frodopwns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@buhongw7583c buhongw7583c merged commit 91f46c0 into Azure:master May 20, 2020
@buhongw7583c buhongw7583c deleted the issue1036AddHealthCheck branch May 20, 2020 02:03
@buhongw7583c buhongw7583c mentioned this pull request May 20, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Add a liveness probe to the Operator deployment
2 participants