-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RedisCache FirewallRule Operator #1095
Conversation
…operator-1 into redisfirewall
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple small changes. One more thing we'll need to do as this is a new CRD added is to also checkin the newly generated zz_deeepcopy file that is generated when you use make generate
locally as this file is not removed from gitignore
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested on a AKS cluster the positive case, case where rediscache was still creating (ultimately both got created). negative case with invalid IP ranges.
Closes #1092
What this PR does / why we need it:
Special notes for your reviewer:
Create a Redis Cache
k create -f config/samples/azure_v1alpha1_rediscache.yaml
Create a Redis Cache FirewallRule
k create -f config/samples/azure_v1alpha1_rediscachefirewallrule.yaml
Verify Exists
k get rediscachefirewallrule [name] -o yaml
Delete FirewallRule
k delete rediscachefirewallrule [name] -o yaml
How does this PR make you feel:
If applicable: