Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RedisCache FirewallRule Operator #1095

Merged
merged 17 commits into from
May 29, 2020
Merged

RedisCache FirewallRule Operator #1095

merged 17 commits into from
May 29, 2020

Conversation

melonrush13
Copy link
Contributor

@melonrush13 melonrush13 commented May 20, 2020

Closes #1092

What this PR does / why we need it:

  • Adds FirewallRule create/delete capabilities to RedisCache
  • Adds documentation for new FirewallRule operator
  • Adds Tests for new FirewallRule operator

Special notes for your reviewer:
Create a Redis Cache
k create -f config/samples/azure_v1alpha1_rediscache.yaml
Create a Redis Cache FirewallRule
k create -f config/samples/azure_v1alpha1_rediscachefirewallrule.yaml
Verify Exists
k get rediscachefirewallrule [name] -o yaml
Delete FirewallRule
k delete rediscachefirewallrule [name] -o yaml

How does this PR make you feel:
gif

If applicable:

  • this PR contains documentation
  • this PR contains tests

Copy link
Contributor

@jananivMS jananivMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small changes. One more thing we'll need to do as this is a new CRD added is to also checkin the newly generated zz_deeepcopy file that is generated when you use make generate locally as this file is not removed from gitignore

api/v1alpha1/rediscachefirewallrule_types.go Outdated Show resolved Hide resolved
@jananivMS jananivMS self-requested a review May 27, 2020 21:35
@jananivMS
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jananivMS jananivMS self-requested a review May 28, 2020 20:26
@jananivMS jananivMS dismissed their stale review May 28, 2020 22:50

changes updated

Copy link
Contributor

@jananivMS jananivMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested on a AKS cluster the positive case, case where rediscache was still creating (ultimately both got created). negative case with invalid IP ranges.

@melonrush13 melonrush13 merged commit e608f4b into Azure:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants