Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rediscache roll actions #1104

Merged
merged 13 commits into from
May 30, 2020
Merged

Rediscache roll actions #1104

merged 13 commits into from
May 30, 2020

Conversation

jpflueger
Copy link
Contributor

Closes #1034

What this PR does / why we need it:
Adds RedisCacheAction resource to trigger access key regeneration.

Special notes for your reviewer:

  1. Create RedisCache resource
  2. Wait until provisioned and note access keys
  3. Create RedisCacheAction resource using the name from step 1
  4. After it has provisioned, check the secret to verify that the access keys have changed
  5. Repeat and set keyvaultToStoreSecrets

How does this PR make you feel:
gif

If applicable:

  • this PR contains documentation
  • this PR contains tests

@frodopwns frodopwns self-assigned this May 27, 2020
frodopwns
frodopwns reviewed May 27, 2020
View reviewed changes
Copy link
Contributor

@frodopwns frodopwns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initial comments from a quick skim, will test next

pkg/resourcemanager/rediscaches/rediscacheaction_reconcile.go Outdated Show resolved Hide resolved
pkg/resourcemanager/rediscaches/rediscacheaction_reconcile.go Outdated Show resolved Hide resolved
frodopwns
frodopwns suggested changes May 28, 2020
View reviewed changes
Copy link
Contributor

@frodopwns frodopwns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to make sure the errors are set in the Status

pkg/resourcemanager/rediscaches/rediscacheaction_reconcile.go Outdated Show resolved Hide resolved
pkg/resourcemanager/rediscaches/rediscacheaction_reconcile.go Outdated Show resolved Hide resolved
pkg/resourcemanager/rediscaches/rediscacheaction_reconcile.go Outdated Show resolved Hide resolved
pkg/resourcemanager/rediscaches/rediscacheaction_reconcile.go Outdated Show resolved Hide resolved
frodopwns
frodopwns approved these changes May 29, 2020
View reviewed changes
Copy link
Contributor

@frodopwns frodopwns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@frodopwns frodopwns removed their assignment May 29, 2020
@jpflueger jpflueger merged commit 47d6fd6 into Azure:master May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frodopwns frodopwns frodopwns approved these changes

@davefellows davefellows Awaiting requested review from davefellows

@jananivMS jananivMS Awaiting requested review from jananivMS

@WilliamMortlMicrosoft WilliamMortlMicrosoft Awaiting requested review from WilliamMortlMicrosoft

Assignees

@jpflueger jpflueger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Task: Re-roll keys for RedisCache
2 participants
@jpflueger @frodopwns