Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support to separate out CRDs in crd folder for helm chart #1105

Merged
merged 30 commits into from
Jun 11, 2020

Conversation

cnadolny
Copy link
Contributor

@cnadolny cnadolny commented May 26, 2020

What this PR does / why we need it:

  • Separates out the CRDs into a separate folder as per Helm3 recommendation
  • Adds instructions for installing operator to a specified namespace (webhook service for CRDs to be installed in a specified namespace)

Special notes for your reviewer:
How to test:

  • Install CRDS in the CRD folder (default is azureoperator-system namespace). Create first instance of ASO with Helm, default values are fine. Make sure ASO is installed and webhooks work well.
  • Now install CRDs in a different namespace. Install ASO using Helm in that namespace. Make sure ASO is installed and webhooks work well.

How does this PR make you feel:
gif

If applicable:

  • this PR contains documentation
  • this PR contains tests

Copy link
Contributor

@jananivMS jananivMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should see if we can parameterize the namespace in. t he CRD definitions instead of hardcoding to azureoperator-system

@jananivMS jananivMS assigned cnadolny and unassigned jananivMS Jun 3, 2020
@cnadolny cnadolny force-pushed the helm-multiple-namespace branch from bd1d24a to b2f3a2a Compare June 5, 2020 03:51
@jananivMS
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jananivMS jananivMS changed the title add support to deploy multiple instances of ASO with Helm Chart add support to separate out CRDs in crd folder for helm chart Jun 7, 2020
@jananivMS jananivMS self-requested a review June 8, 2020 04:02
@jananivMS jananivMS assigned jananivMS and unassigned cnadolny Jun 8, 2020
@jananivMS
Copy link
Contributor

@cnadolny - Does the documentation here need to change for how to update the helm charts and update them in the repo when a new CRD is added? Step 12 here - https://github.com/Azure/azure-service-operator/blob/master/docs/howto/newoperatorguide.md

@cnadolny cnadolny force-pushed the helm-multiple-namespace branch from 18c8ca5 to cda5c4f Compare June 10, 2020 16:20
@cnadolny
Copy link
Contributor Author

@cnadolny - Does the documentation here need to change for how to update the helm charts and update them in the repo when a new CRD is added? Step 12 here - https://github.com/Azure/azure-service-operator/blob/master/docs/howto/newoperatorguide.md

updated the docs

Copy link
Contributor

@frodopwns frodopwns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cnadolny cnadolny merged commit 7867819 into Azure:master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants