-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support to separate out CRDs in crd folder for helm chart #1105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should see if we can parameterize the namespace in. t he CRD definitions instead of hardcoding to azureoperator-system
bd1d24a
to
b2f3a2a
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@cnadolny - Does the documentation here need to change for how to update the helm charts and update them in the repo when a new CRD is added? Step 12 here - https://github.com/Azure/azure-service-operator/blob/master/docs/howto/newoperatorguide.md |
18c8ca5
to
cda5c4f
Compare
updated the docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What this PR does / why we need it:
Special notes for your reviewer:
How to test:
How does this PR make you feel:
If applicable: