Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding cainjection file validation check #1127

Merged
merged 15 commits into from
Jun 4, 2020
Merged

adding cainjection file validation check #1127

merged 15 commits into from
Jun 4, 2020

Conversation

jpflueger
Copy link
Contributor

Closes #1119

What this PR does / why we need it:
Adds a validation check to the pipeline to enforce the cainjection patch annotations for certmanager.

Special notes for your reviewer:
Change the annotation in a file like config/crd/patches/cainjection_in_rediscacheactions.yaml to be:

# The following patch adds a directive for certmanager to inject CA into the CRD
# CRD conversion requires k8s 1.13 or later.
apiVersion: apiextensions.k8s.io/v1beta1
kind: CustomResourceDefinition
metadata:
  annotations:
    certmanager.k8s.io/inject-ca-from: $(CERTIFICATE_NAMESPACE)/$(CERTIFICATE_NAME)
  name: rediscacheactions.azure.microsoft.com

And then run make validate-cainjection-files to see the output.

The pipeline in this PR will fail intentionally until PR #1124 is merged in.

How does this PR make you feel:
gif

@jananivMS jananivMS self-assigned this Jun 3, 2020
jananivMS
jananivMS previously approved these changes Jun 3, 2020
Copy link
Contributor

@jananivMS jananivMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jananivMS
Copy link
Contributor

@jpflueger The changes look good but lets wait for the other PR to be merged before merging this to avoid pipeline failures

Copy link
Contributor

@jananivMS jananivMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jpflueger jpflueger merged commit 0f743cb into Azure:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants