-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding cainjection file validation check #1127
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpflueger
requested review from
davefellows,
frodopwns,
jananivMS and
WilliamMortlMicrosoft
as code owners
June 2, 2020 17:37
…ervice-operator into cainjection-validation
jananivMS
previously approved these changes
Jun 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@jpflueger The changes look good but lets wait for the other PR to be merged before merging this to avoid pipeline failures |
…ervice-operator into cainjection-validation
…ervice-operator into cainjection-validation
…ervice-operator into cainjection-validation
jananivMS
approved these changes
Jun 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1119
What this PR does / why we need it:
Adds a validation check to the pipeline to enforce the cainjection patch annotations for certmanager.
Special notes for your reviewer:
Change the annotation in a file like
config/crd/patches/cainjection_in_rediscacheactions.yaml
to be:And then run
make validate-cainjection-files
to see the output.The pipeline in this PR will fail intentionally until PR #1124 is merged in.
How does this PR make you feel: