Fix RBAC issues with postgresqluser CRD #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jananivMS
requested review from
davefellows,
frodopwns and
WilliamMortlMicrosoft
as code owners
melonrush13
previously approved these changes
Jun 3, 2020
There was a problem hiding this comment.
LGTM!
Looks like it is in the current PR for MySQL too which is in review. We should remove it there too when/if you fix that delete bug!
jananivMS
changed the title
jananivMS
requested review from
buhongw7583c and
melonrush13
and removed request for
buhongw7583c
buhongw7583c
approved these changes
Jun 4, 2020
|
@jananivMS Janani, I can now successfully deploy the CRD on AKS and verify the creation of postgresqlserver/database/firewallrule/user. But seems the PR can only be reviewed with at least one of the code owners' approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the Postgresqluser PR added a kubebuilder directive for shortname that defined a different name for the CRD. This is causing issues when making helm chart manifests and deploying to AKS cluster.
Removing this directive now as we are looking at shortnames in a different PR.
After this, I still have RBAC issues with this CRD. So had to enable RBAC through the kubebuilder directive in main.go. This aberration seems mostly because of not using Kubebuilder to generate the CRD