Refactor Custom Secrets and AzureSQLUser #1153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamMortlMicrosoft
added
documentation
WilliamMortlMicrosoft
requested review from
davefellows,
frodopwns,
jananivMS,
matthchr,
Porges and
theunrepentantgeek
as code owners
added 2 commits
June 9, 2020 14:52
Comment on lines
+286
to
+295
| if strings.Contains(err.Error(), "FlattenedSecretsNotSupported") { // kube client does not support Flatten | ||
| err = secretClient.Upsert(ctx, | ||
| types.NamespacedName{Namespace: userSecretNamespacedName.Namespace, Name: instance.Name}, | ||
| formattedSecrets) | ||
| if err != nil { | ||
| return fmt.Errorf("Upsert into KubeClient without flatten failed") | ||
| } | ||
| instance.Status.FlattenedSecrets = false | ||
| } | ||
| } |
There was a problem hiding this comment.
@jananivMS I followed your lead on this
|
Waiting for this to pass and then Ill pull the WIP off |
|
Will make sure to rebase and merge when ready so that Denis gets credit for his contributions |
Comment on lines
+177
to
+180
| keyVaultEnabled := reflect.TypeOf(secretClient).Elem().Name() == "KeyvaultSecretClient" | ||
| if !keyVaultEnabled { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
should I remove this @jananivMS
WilliamMortlMicrosoft
changed the title
suggestion 1 Co-authored-by: Bevan Arps <bevan.arps@microsoft.com>
suggestion #1 Co-authored-by: Bevan Arps <bevan.arps@microsoft.com>
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Closing this given its age and the fact that an alternative approach is about to merge here #1358 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Secrets Pkg:
AzureSqlUser:
The flatten option has been kept in the implementation because we need to have a way to ask the secrets package to create individual secrets rather than the default behavior of working with a map/json array. The kube client now returns an error when asked to flatten because that doesn't make sense in-context (Kube only works with map objects for secrets).
Closes #887
Special notes for your reviewer:
How does this PR make you feel:
If applicable: