Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs update #1185

Merged
merged 14 commits into from
Jun 26, 2020
Merged

Docs update #1185

merged 14 commits into from
Jun 26, 2020

Conversation

sakthi-vetrivel
Copy link

No description provided.

docs/howto/contents.md Outdated Show resolved Hide resolved
Copy link
Member

@theunrepentantgeek theunrepentantgeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, just a few minor tweaks.


1. Make sure `kubectl` is configured to connect to the Kubernetes cluster you want to deploy Azure Service Operators to.
1. Make sure `kubectl` is configured to connect to the Kubernetes cluster you want to deploy Azure Service Operator to.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps

Suggested change
1. Make sure `kubectl` is configured to connect to the Kubernetes cluster you want to deploy Azure Service Operator to.
1. Make sure `kubectl` is configured to connect to the Kubernetes cluster you want to deploy Azure Service Operator into.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think both of these are correct

docs/design/controlflow.md Outdated Show resolved Hide resolved
docs/design/controlflow.md Outdated Show resolved Hide resolved
docs/faq.md Outdated Show resolved Hide resolved
docs/faq.md Outdated Show resolved Hide resolved
frodopwns and others added 4 commits June 26, 2020 12:32
Co-authored-by: Bevan Arps <bevan.arps@microsoft.com>
Co-authored-by: Bevan Arps <bevan.arps@microsoft.com>
Co-authored-by: Bevan Arps <bevan.arps@microsoft.com>
Co-authored-by: Bevan Arps <bevan.arps@microsoft.com>
docs/howto/contents.md Outdated Show resolved Hide resolved
docs/howto/contents.md Outdated Show resolved Hide resolved
docs/howto/contents.md Outdated Show resolved Hide resolved
docs/howto/contents.md Outdated Show resolved Hide resolved
Copy link
Contributor

@frodopwns frodopwns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@frodopwns frodopwns merged commit 51c87ac into master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants