more in-depth quick start guide #1196
Conversation
frodopwns
requested review from
davefellows,
jananivMS,
matthchr,
Porges,
theunrepentantgeek and
WilliamMortlMicrosoft
as code owners
frodopwns
changed the title
docs/howto/quickstart.md
Outdated
| VOTES_APP_INSTANCE_NAME="<alias>" # only alpha numeric | ||
| TENANT_ID="" | ||
| SUBSCRIPTION_ID="" |
There was a problem hiding this comment.
Can we add instructions on how people can get the values for these variables?
There was a problem hiding this comment.
Please also add some links that describe what those ID are
There was a problem hiding this comment.
I'm adding the instructions for finding them. I'm not sure a quick start for someone completely unfamiliar to Azure is entirely in scope here. Plus, I don't know if MS has a definition listed anywhere.
| TENANT_ID="" | ||
| SUBSCRIPTION_ID="" |
There was a problem hiding this comment.
I would be tempted to assume that most people will already be logged into azure, and flip these on their heads.
Maybe tell people to:
az login and az account set -s YOUR_SUBSCRIPTION_ID
at the top, and then:
| TENANT_ID="" | |
| SUBSCRIPTION_ID="" | |
| TENANT_ID=$(az account show | jq -r .homeTenantId) | |
| SUBSCRIPTION_ID=$(az account show | jq -r .id) |
here?
There was a problem hiding this comment.
hmm, yes, this looks better to me
There was a problem hiding this comment.
although....not sure if the windows folks will get this to work in powershell...
There was a problem hiding this comment.
guess since we are already using jq it doesn't matter too much
There was a problem hiding this comment.
We could use --query and --output tsv instead of jq, similar to the other examples in the file:
TENANT_ID=$(az account show --query homeTenantId -o tsv)
SUBSCRIPTION_ID=$(az account show --query id -o tsv)Co-authored-by: Sakthi Vetrivel <suvetriv@microsoft.com>
Co-authored-by: Sakthi Vetrivel <suvetriv@microsoft.com>
Co-authored-by: David Laban <alsuren@gmail.com>
Co-authored-by: David Laban <alsuren@gmail.com>
Co-authored-by: David Laban <alsuren@gmail.com>
Co-authored-by: Sakthi Vetrivel <suvetriv@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## master #1196 +/- ##
=======================================
Coverage 62.13% 62.13%
=======================================
Files 161 161
Lines 10695 10695
=======================================
Hits 6645 6645
Misses 3414 3414
Partials 636 636 Continue to review full report at Codecov.
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This guide walks the user through deploying an application using ASO to an AKS cluster pretty much from scratch.
What this PR does / why we need it:
Initial quick start is over simplified.