Add support for SQL Database SKU and MaxSizeBytes #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthchr
requested review from
davefellows,
frodopwns,
jananivMS,
Porges,
theunrepentantgeek and
WilliamMortlMicrosoft
as code owners
Porges
reviewed
Jul 16, 2020
|
Seems to make sense 👍 |
Porges
reviewed
Jul 16, 2020
matthchr
force-pushed
the
feature/sql-sku-support
branch
from
f4d52e0 to
f685204
Compare
Porges
previously approved these changes
Jul 17, 2020
|
@matthchr because the spec changed here you will need to update the helm templates then commit the changed files |
frodopwns
suggested changes
Jul 17, 2020
|
Probably should also update the sample manifest and/or the docs https://github.com/Azure/azure-service-operator/blob/master/config/samples/azure_v1beta1_azuresqldatabase.yaml |
frodopwns
reviewed
Jul 17, 2020
| return future.Response(), err | ||
| } | ||
|
|
||
| // AddLongTermRetention enables / disables long term retention | ||
| func (_ *AzureSqlDbManager) AddLongTermRetention(ctx context.Context, resourceGroupName string, serverName string, databaseName string, weeklyRetention string, monthlyRetention string, yearlyRetention string, weekOfYear int32) (*http.Response, error) { | ||
|
|
||
| longTermClient, err := azuresqlshared.GetBackupLongTermRetentionPoliciesClient() | ||
| // TODO: Probably shouldn't return a response at all in the err case here (all through this function) |
There was a problem hiding this comment.
I think at times there have been attempts to make the Response more user friendly so we could rely on it for error handling. In the end we have had to just use data embedded in the error types.
frodopwns
reviewed
Jul 17, 2020
pkg/resourcemanager/azuresql/azuresqldb/azuresqldb_reconcile.go
Outdated
Show resolved
Hide resolved
frodopwns
reviewed
Jul 17, 2020
matthchr
force-pushed
the
feature/sql-sku-support
branch
from
f685204 to
0c71314
Compare
frodopwns
suggested changes
Jul 17, 2020
| @@ -22,13 +49,16 @@ type AzureSqlDatabaseSpec struct { | |||
| // +kubebuilder:validation:Required | |||
| ResourceGroup string `json:"resourceGroup"` | |||
| Server string `json:"server"` | |||
| Edition DBEdition `json:"edition"` | |||
| Edition DBEdition `json:"edition"` // TODO: Remove this in v1beta2 | |||
There was a problem hiding this comment.
this now needs to include omitempty
matthchr
force-pushed
the
feature/sql-sku-support
branch
3 times, most recently
from
1cf6e02 to
77dbad2
Compare
matthchr
force-pushed
the
feature/sql-sku-support
branch
from
77dbad2 to
d1878fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1226
What this PR does / why we need it:
Allow customers full control over SQL server SKU and MaxSize
If applicable: