Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update port for webhook service to 443 #1252

Merged
merged 2 commits into from
Aug 10, 2020
Merged

Conversation

madorn
Copy link
Contributor

@madorn madorn commented Aug 7, 2020

Update webhook service to listen on 443. This will prevent the need to update the current CRDs that specify 443 in their conversion config.

Closes #1251

What this PR does / why we need it:
Without this change, creating Custom Resources that have CRD conversion webhook configs will fail.

How does this PR make you feel:
:)

Update webhook service to listen on 443. This will prevent the need to update the current CRDs that specify 443 in their conversion config.
@ghost
Copy link

ghost commented Aug 7, 2020

CLA assistant check
All CLA requirements met.

@theunrepentantgeek
Copy link
Member

theunrepentantgeek commented Aug 9, 2020

There's a potential conflict here with recent PR #1249 which was all about moving away from port 443 so that the operator can be used in more restrictive environments. @babbageclunk will know more.

Copy link
Member

@babbageclunk babbageclunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out @madorn!

@babbageclunk
Copy link
Member

There's a potential conflict here with recent PR #1249 which was all about moving away from port 443 so that the operator can be used in more restrictive environments. @babbageclunk will know more.

It turns out my change was overenthusiastic about updating ports to 9443. It should just have been to make the operator pod listen on 9443 (so it can start in environments where it's not running as root), but leave the webhook service listening on 443, because existing resources are configured with that port by default for the conversion webhook. (See conversion.webhookClientConfig.service in the generated CRD.)

@babbageclunk
Copy link
Member

babbageclunk commented Aug 9, 2020

I'm going to land this change and then add another PR to update the charts.

@Azure Azure deleted a comment from azure-pipelines bot Aug 9, 2020
@babbageclunk
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

samples are not working
3 participants