Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dummy caBundle value in webhook config #1278

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Remove dummy caBundle value in webhook config #1278

merged 1 commit into from
Sep 24, 2020

Conversation

matthchr
Copy link
Member

@matthchr
Remove dummy caBundle value in webhook config
798df88 
  - This prevents resourceVersion change when CRD is reapplied.
  - See kubernetes-sigs/kubebuilder#1684 for
    more details.
  - Fixes Azure#1261.
babbageclunk
babbageclunk approved these changes Sep 24, 2020
View reviewed changes
Copy link
Member

@babbageclunk babbageclunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I love when a fix is essentially "stop doing this thing that isn't needed anymore and everything will just work".

@matthchr matthchr merged commit cf3e91c into Azure:master Sep 24, 2020
@matthchr matthchr deleted the feature/fix-cabundle branch September 24, 2020 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davefellows davefellows davefellows approved these changes

@theunrepentantgeek theunrepentantgeek theunrepentantgeek approved these changes

@babbageclunk babbageclunk babbageclunk approved these changes

@frodopwns frodopwns Awaiting requested review from frodopwns

@jananivMS jananivMS Awaiting requested review from jananivMS

@Porges Porges Awaiting requested review from Porges

@WilliamMortlMicrosoft WilliamMortlMicrosoft Awaiting requested review from WilliamMortlMicrosoft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Reapplying CRDs with conversion webhooks + certmanager causes re-reconciliation
4 participants
@matthchr @babbageclunk @theunrepentantgeek @davefellows