Update MySQL user roles when users are modified #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthchr
requested review from
babbageclunk,
davefellows,
frodopwns,
jananivMS,
Porges,
theunrepentantgeek and
WilliamMortlMicrosoft
as code owners
matthchr
changed the title
babbageclunk
previously approved these changes
Nov 24, 2020
matthchr
force-pushed
the
feature/mysql-role-updates
branch
2 times, most recently
from
5c378f9 to
8becf7e
Compare
Comment on lines
102
to
103
| tsql := fmt.Sprintf("SELECT PRIVILEGE_TYPE from information_schema.SCHEMA_PRIVILEGES WHERE GRANTEE = '''%s''@''%%''' and TABLE_SCHEMA = ?", user) | ||
| rows, err := db.QueryContext(ctx, tsql, database) |
There was a problem hiding this comment.
Grantee can be a parameter here, can't it? You'd still have to build the weird formatting with the quotes and @ - that's a bit easier if you don't need to sql-quote it.
Suggested change
| tsql := fmt.Sprintf("SELECT PRIVILEGE_TYPE from information_schema.SCHEMA_PRIVILEGES WHERE GRANTEE = '''%s''@''%%''' and TABLE_SCHEMA = ?", user) | |
| rows, err := db.QueryContext(ctx, tsql, database) | |
| tsql := "select privilege_type from information_schema.schema_privileges where grantee = ? and table_schema= ?" | |
| formattedUser := fmt.Sprintf("'%s'@'%'", user) | |
| rows, err := db.QueryContext(ctx, tsql, formattedUser, database) |
I tend to make queries all lowercase, not sure what the standard is - a lot of people prefer SQL keywords in uppercase.
There was a problem hiding this comment.
Yeah all of the existing queries we have are all uppercase for the keywords at least. I'll fix this
matthchr
force-pushed
the
feature/mysql-role-updates
branch
from
8becf7e to
60c1f5d
Compare
babbageclunk
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to but does not resolve #1311
What this PR does / why we need it:
We need to decide if we want to support this functionality at all. It's "easiest" for MySQL and harder for Azure SQL (I haven't even looked into PostgreSQL).
If applicable: