Update to support MySQL AAD users and groups too #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthchr
requested review from
babbageclunk,
davefellows,
frodopwns,
jananivMS,
Porges,
theunrepentantgeek and
WilliamMortlMicrosoft
as code owners
matthchr
force-pushed
the
feature/mysql-users-and-groups
branch
from
25e5a33 to
d3b67f1
Compare
babbageclunk
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds support for MySQL AAD Users and Groups.
Special notes for your reviewer:
Difficult to test currently given the existing test infrastructure. As before with the Managed Identity pieces of this work I have confirmed this works manually (and we can rely somewhat on the standard user create tests to test the basic connect/etc pieces of the workflow).
If applicable: