Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release scripts #1373

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Fix release scripts #1373

merged 1 commit into from
Feb 9, 2021

Conversation

matthchr
Copy link
Member

@matthchr matthchr commented Feb 9, 2021

If applicable:

  • this PR contains documentation
  • this PR contains tests

@matthchr matthchr changed the title Fix script Fix release scripts Feb 9, 2021
@Porges
Copy link
Member

Porges commented Feb 9, 2021 •
edited
Loading

@matthchr is the fix just to remove Helm?

@matthchr
Copy link
Member Author

matthchr commented Feb 9, 2021

No it's also to switch away from $() syntax because that's specific to DevOps and use env variables instead ($... or ${})

@matthchr matthchr merged commit 86561c3 into Azure:master Feb 9, 2021
@matthchr matthchr deleted the feature/release-script-fix branch February 9, 2021 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Porges Porges Porges approved these changes

@babbageclunk babbageclunk Awaiting requested review from babbageclunk

@davefellows davefellows Awaiting requested review from davefellows

@jananivMS jananivMS Awaiting requested review from jananivMS

@theunrepentantgeek theunrepentantgeek Awaiting requested review from theunrepentantgeek

@WilliamMortlMicrosoft WilliamMortlMicrosoft Awaiting requested review from WilliamMortlMicrosoft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthchr @Porges