Fix v1 secret naming #1380
Merged
Fix v1 secret naming #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthchr
requested review from
babbageclunk,
davefellows,
jananivMS,
Porges,
theunrepentantgeek and
WilliamMortlMicrosoft
as code owners
matthchr
force-pushed
the
feature/fix-v1-secret-naming
branch
2 times, most recently
from
a26d77e to
d5c5c2c
Compare
babbageclunk
previously approved these changes
Feb 14, 2021
matthchr
force-pushed
the
feature/fix-v1-secret-naming
branch
3 times, most recently
from
7649ac5 to
eada53f
Compare
- Fix issue where namespace was mistakenly included in v1 secret
naming key generation. Some resources are not expected to have
namespace prefix in certain KeyVault scenarios.
matthchr
force-pushed
the
feature/fix-v1-secret-naming
branch
from
eada53f to
72c8234
Compare
matthchr
force-pushed
the
feature/fix-v1-secret-naming
branch
from
72c8234 to
0fbbe45
Compare
babbageclunk
previously approved these changes
Feb 17, 2021
- Due to capacity constraints. We can move back later.
matthchr
force-pushed
the
feature/fix-v1-secret-naming
branch
from
287a0fa to
d52c644
Compare
babbageclunk
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
naming key generation. Some resources are not expected to have
namespace prefix in certain KeyVault scenarios.
How does this PR make you feel:
If applicable: