SqlDatabase controller changes #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erator into jananiv/azuresqltests
…erator into jananiv/azuresqltests
* improve tests with parallel execution and rm sleep * fix the tests to run on kindcluster
* feat: implement keyvault controller * Ace's KV changes with updates * Added an event for the final successful provisioning * Updated changes based on the PR comments * removing unwanted file * making resource group name the one in the keyvault yaml Co-authored-by: Ace Eldeib <alexeldeib@gmail.com>
…erator into jananiv/azuresqltests
…erator into jananiv/azuresqltests
jananivMS
changed the title
frodopwns
reviewed
Aug 27, 2019
| Location string `json:"location"` | ||
| ResourceGroup string `json:"resourcegroup,omitempty"` | ||
| Server string `json:"server"` | ||
| Edition sql.DBAddition `json:"edition"` |
There was a problem hiding this comment.
IS this the one that is meant to be Edition?
frodopwns
reviewed
Aug 27, 2019
| @@ -1,7 +1,9 @@ | |||
| apiVersion: azure.microsoft.com/v1 | |||
| kind: SqlDatabase | |||
| metadata: | |||
| name: sqldatabase-sample | |||
| name: samplesqldb123 | |||
There was a problem hiding this comment.
Suggested change
| name: samplesqldb123 | |
| name: sqldatabase-sample |
frodopwns
reviewed
Aug 27, 2019
frodopwns
reviewed
Aug 27, 2019
frodopwns
reviewed
Aug 27, 2019
| server := instance.Spec.Server | ||
| groupName := instance.Spec.ResourceGroup | ||
| var dbEdition sql.DBAddition | ||
| dbEdition = instance.Spec.Edition |
There was a problem hiding this comment.
why define this on the previous line?
Suggested change
| dbEdition = instance.Spec.Edition | |
| dbEdition := instance.Spec.Edition |
frodopwns
reviewed
Aug 27, 2019
frodopwns
suggested changes
Aug 27, 2019
Porges
pushed a commit
that referenced
this pull request
May 11, 2021
* Fix usage of ** in glob
- Add new dependency becuase golang filepath.glob doesn't support
recursive matching.
* Allow output directory to be configured
- This fixes #144.
- Improved configuration yaml file property casing.
* Add makefile target for running k8sinfra-gen
* Little comment type fixup
* Allow `make gen-arm` to be rerun by deleting the generated code
Since the generated code doesn't currently build it would prevent
`make gen-arm` from being rerun until the apis directory was
removed.
Hit a bug in codegen.isFileGenerated that would fail to close
files - move the deferred close to before the early return.
* Add clarifying comment to Makefile
Co-authored-by: Christian Muirhead <christian.muirhead@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #133
What this PR does / why we need it:
Adds the reconciler logic for SqlDatabase to create and delete Sql Databases
Special notes for your reviewer:
Test create and delete of Sql database using the kubectl apply -f "config/samples/azure_v1_sqldatabse,yaml"
If applicable: