Use correct DNS suffix for MySQLAADUser #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthchr
requested review from
babbageclunk,
davefellows,
Porges and
theunrepentantgeek
as code owners
matthchr
force-pushed
the
aso/mysqlaaduser-natcloud-fix
branch
from
7d5d96a to
642c0d5
Compare
|
I tested this manually and confirmed when the As with other AAD things this is a bit tricky to test in an automated fashion with our current test infrastructure. |
Porges
approved these changes
May 21, 2021
Codecov Report
@@ Coverage Diff @@
## master #1499 +/- ##
=======================================
Coverage 62.17% 62.17%
=======================================
Files 163 163
Lines 10739 10739
=======================================
Hits 6677 6677
Misses 3422 3422
Partials 640 640 Continue to review full report at Codecov.
|
babbageclunk
approved these changes
May 21, 2021
babbageclunk
pushed a commit
to babbageclunk/azure-service-operator
that referenced
this pull request
May 23, 2021
Co-authored-by: George Pollard <gpollard@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix bug where the public DNS suffix was always used even in nonpublic environments.
Closes #1496