Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding fields to SqlFirewallRule spec #150

Merged
merged 1 commit into from
Aug 28, 2019
Merged

Adding fields to SqlFirewallRule spec #150

merged 1 commit into from
Aug 28, 2019

Conversation

melonrush13
Copy link
Contributor

#147

What this PR does / why we need it:
Adding StartIPAddress and EndIPAddress to SqlFireWallRule spec for future implementation

Special notes for your reviewer:

If applicable:

  • this PR contains documentation
  • this PR contains tests

Copy link
Contributor

@frodopwns frodopwns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@melonrush13 melonrush13 merged commit 13fd632 into Azure:azure-sql Aug 28, 2019
Porges pushed a commit that referenced this pull request May 11, 2021
This will help us trace a generated package back to the code that
produced it. The git commit hash (and whether the tree is dirty) is
fed into the build from the Makefile.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants