Create conversions package #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
babbageclunk,
davefellows,
matthchr and
Porges
as code owners
theunrepentantgeek
force-pushed
the
feature/conversions-package
branch
from
7e05710 to
326c98a
Compare
babbageclunk
approved these changes
May 27, 2021
|
|
||
| import ( | ||
| "fmt" | ||
| "github.com/Azure/azure-service-operator/hack/generator/pkg/astmodel" |
There was a problem hiding this comment.
Move this down into a separate this-module stanza along with the astbuilder import?
Comment on lines
9
to
10
| "github.com/Azure/azure-service-operator/hack/generator/pkg/astmodel" | ||
| "github.com/Azure/azure-service-operator/hack/generator/pkg/conversions" |
Comment on lines
9
to
10
| "bytes" | ||
| "github.com/Azure/azure-service-operator/hack/generator/pkg/astmodel" |
| } | ||
| } | ||
|
|
||
| //TODO: Remove this? |
There was a problem hiding this comment.
Those methods were introduced as a part of relocating things one by one into the new package, but I'll keep them. Fixed the comments.
|
|
||
| import ( | ||
| "github.com/Azure/azure-service-operator/hack/generator/pkg/astmodel" |
|
|
||
| import ( | ||
| "github.com/Azure/azure-service-operator/hack/generator/pkg/astmodel" |
Codecov Report
@@ Coverage Diff @@
## master #1520 +/- ##
==========================================
+ Coverage 63.23% 63.25% +0.01%
==========================================
Files 175 175
Lines 11583 11597 +14
==========================================
+ Hits 7325 7336 +11
- Misses 3601 3604 +3
Partials 657 657
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Moves much of the code around creation of storage variants out of the astmodel package and into a package dedicated to generation of conversions.
Requires PR #1495 to be merged first.PR #1495 has been merged.Special notes for your reviewer:
The PR is almost entirely moving files and renaming types (see below for the exception). However, not every file rename has been detected and correctly shown in the PR, so in some cases we see new-file + file-deleted.
The one functional change is that functions are named for the type being converted, not for the version. This can be seen in the changes to the (relocated) golden files, where
ConvertToVNext()now becomesAssignPropertiesToPerson(). In the actuall generated code, where the versions are date based, the change will look likeConvertToV20180501()becomingAssignPropertiesToBatchAccount().How does this PR make you feel:
If applicable: