Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v2 Servicebus Topic CRUD test #1522

Merged
merged 2 commits into from
May 30, 2021
Merged

Add v2 Servicebus Topic CRUD test #1522

merged 2 commits into from
May 30, 2021

Conversation

Porges
Copy link
Member

@Porges Porges commented May 27, 2021

Adds a Servicebus Standard SKU namespace test (topics cannot be created in Basic SKU) and subtests to create Queues & Topics.

Also adds a helper to run subtests in parallel and wait for them to finish.

Refs: #1192, #1175

How does this PR make you feel:
gif

@Porges Porges added P2 test Test refactoring related tasks labels May 27, 2021
@Porges Porges changed the base branch from master to docker-build May 27, 2021 22:51
@Porges Porges added this to the codegen-alpha-0 milestone May 27, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2021

Codecov Report

Merging #1522 (7098553) into master (aa3d6f2) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1522      +/-   ##
==========================================
+ Coverage   63.22%   63.23%   +0.01%     
==========================================
  Files         175      175              
  Lines       11583    11583              
==========================================
+ Hits         7323     7325       +2     
+ Misses       3602     3601       -1     
+ Partials      658      657       -1     
Impacted Files Coverage Δ
hack/generated/pkg/testcommon/test_context.go 58.82% <0.00%> (+2.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa3d6f2...7098553. Read the comment docs.

Base automatically changed from docker-build to master May 30, 2021 20:41
@Porges Porges force-pushed the servicebus-topic-test branch from 2c38d37 to 7098553 Compare May 30, 2021 20:46
@Porges Porges merged commit dae753e into master May 30, 2021
@Porges Porges deleted the servicebus-topic-test branch May 30, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Test refactoring related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants