Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v2 VNet CRUD test #1523

Merged
merged 1 commit into from
May 30, 2021
Merged

Add v2 VNet CRUD test #1523

merged 1 commit into from
May 30, 2021

Conversation

Porges
Copy link
Member

@Porges Porges commented May 28, 2021

Add Create/Delete test for Virtual Networks in codegen controller.

Ref: #1192

How does this PR make you feel:
gif

@Porges Porges added this to the codegen-alpha-0 milestone May 28, 2021
@Porges Porges added the high-priority Issues we intend to prioritize (security, outage, blocking bug) label May 28, 2021
@Porges Porges added the test Test refactoring related tasks label May 28, 2021
@Porges Porges force-pushed the servicebus-topic-test branch from 2c38d37 to 7098553 Compare May 30, 2021 20:46
@Porges Porges force-pushed the virtual-networks branch from b401342 to 9095628 Compare May 30, 2021 20:48
Base automatically changed from servicebus-topic-test to master May 30, 2021 21:07
@Porges Porges force-pushed the virtual-networks branch from 9095628 to a55282c Compare May 30, 2021 21:08
@codecov-commenter
Copy link

Codecov Report

Merging #1523 (a55282c) into master (dae753e) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1523      +/-   ##
==========================================
- Coverage   63.23%   63.16%   -0.08%     
==========================================
  Files         175      175              
  Lines       11583    11583              
==========================================
- Hits         7325     7316       -9     
- Misses       3601     3608       +7     
- Partials      657      659       +2     
Impacted Files Coverage Δ
hack/generated/pkg/testcommon/test_context.go 58.82% <ø> (ø)
...ted/pkg/reconcilers/azure_deployment_reconciler.go 56.78% <0.00%> (-2.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dae753e...a55282c. Read the comment docs.

@Porges Porges merged commit 8f36359 into master May 30, 2021
@Porges Porges deleted the virtual-networks branch May 30, 2021 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high-priority Issues we intend to prioritize (security, outage, blocking bug) test Test refactoring related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants