Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small ARM conversion bug #1524

Merged
merged 1 commit into from
May 28, 2021

Conversation

matthchr
Copy link
Member

If there are no properties to actually perform conversion on, just return nil.

@matthchr
Copy link
Member Author

Not sure if linting on the golden files would've caught this, but another situation where the golden files actually had a compiler error in it and I just didn't notice it initially.

@codecov-commenter
Copy link

Codecov Report

Merging #1524 (ba6f999) into master (662f514) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1524      +/-   ##
==========================================
+ Coverage   63.20%   63.23%   +0.03%     
==========================================
  Files         175      175              
  Lines       11573    11583      +10     
==========================================
+ Hits         7315     7325      +10     
  Misses       3601     3601              
  Partials      657      657              
Impacted Files Coverage Δ
...armconversion/convert_from_arm_function_builder.go 89.09% <100.00%> (+0.34%) ⬆️
...ack/generator/pkg/astmodel/armconversion/shared.go 82.45% <100.00%> (+1.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 662f514...ba6f999. Read the comment docs.

@matthchr matthchr merged commit 6fcda88 into Azure:master May 28, 2021
@matthchr matthchr deleted the feature/fix-arm-conversion branch May 28, 2021 00:52
@Porges Porges added this to the codegen-alpha-0 milestone May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants