Specification for Preservation of ARM API Versioning #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
babbageclunk,
davefellows,
matthchr and
Porges
as code owners
babbageclunk
reviewed
Jun 3, 2021
docs/design/api-versions.md
Outdated
|
|
||
| ### API Preservation | ||
|
|
||
| When generating the storage variants of each resource, we'll inject a new `ApiVersion` property of type **string**. |
There was a problem hiding this comment.
Does this need updating? In the whiteboard discussion we had you were talking about a GVK property instead?
There was a problem hiding this comment.
Yes, I've now updated the spec.
theunrepentantgeek
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1538 +/- ##
=======================================
Coverage 63.43% 63.43%
=======================================
Files 181 181
Lines 11796 11796
=======================================
Hits 7483 7483
Misses 3644 3644
Partials 669 669 Continue to review full report at Codecov.
|
babbageclunk
approved these changes
Jun 16, 2021
theunrepentantgeek
force-pushed
the
spec/api-versioning
branch
from
50c01e2 to
2b43b6f
Compare
babbageclunk
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Initial specification for how we will preserve the correct API version and ensure we use it when interacting with ARM.
Resolves #1468
Direct link for viewing with embedded diagrams:
https://github.com/Azure/azure-service-operator/blob/spec/api-versioning/docs/design/api-versions.md
How does this PR make you feel:
If applicable: