Flattening #1548
Merged
Flattening #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Porges
requested review from
babbageclunk,
davefellows,
matthchr and
theunrepentantgeek
as code owners
Porges
commented
Jun 2, 2021
Codecov Report
@@ Coverage Diff @@
## master #1548 +/- ##
==========================================
- Coverage 63.26% 62.36% -0.91%
==========================================
Files 184 186 +2
Lines 11926 12256 +330
==========================================
+ Hits 7545 7643 +98
- Misses 3707 3926 +219
- Partials 674 687 +13
Continue to review full report at Codecov.
|
Porges
commented
Jun 8, 2021
Porges
commented
Jun 8, 2021
hack/generator/pkg/codegen/testdata/Flattening/FlattenedPropertiesAreFlattened.golden
Show resolved
Hide resolved
hack/generator/pkg/astmodel/armconversion/convert_to_arm_function_builder.go
Outdated
Show resolved
Hide resolved
hack/generator/pkg/astmodel/armconversion/convert_to_arm_function_builder.go
Show resolved
Hide resolved
hack/generator/pkg/astmodel/armconversion/convert_to_arm_function_builder.go
Outdated
Show resolved
Hide resolved
hack/generator/pkg/codegen/testdata/Flattening/FlattenedPropertiesAreFlattened.golden
Show resolved
Hide resolved
|
This will probably have conflicts with #1556 - we should coordinate. |
matthchr
approved these changes
Jun 10, 2021
hack/generator/pkg/astmodel/armconversion/convert_from_arm_function_builder.go
Outdated
Show resolved
Hide resolved
hack/generator/pkg/astmodel/armconversion/convert_from_arm_function_builder.go
Outdated
Show resolved
Hide resolved
hack/generator/pkg/astmodel/armconversion/convert_from_arm_function_builder.go
Show resolved
Hide resolved
hack/generator/pkg/astmodel/armconversion/convert_from_arm_function_builder.go
Outdated
Show resolved
Hide resolved
babbageclunk
approved these changes
Jun 11, 2021
| @@ -142,7 +142,9 @@ func (codeGenContext *CodeGenerationContext) GetAllReachableTypes() Types { | |||
| for _, pkgImport := range codeGenContext.packageImports.AsSlice() { | |||
| types, found := codeGenContext.GetTypesInPackage(pkgImport.packageReference) | |||
| if found { | |||
| result.AddTypes(types) | |||
| for k, v := range types { | |||
There was a problem hiding this comment.
Presumably because this can have replacements that change the type the definition points to?
There was a problem hiding this comment.
It can find duplicates, somehow. I didn't think about it too much 🙂
Co-authored-by: Christian Muirhead <christian.muirhead@microsoft.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1447
What this PR does / why we need it:
Applies the
x-ms-client-flattenattribute when it is present in the Swagger.Special notes for your reviewer:
Highly recommend reviewing ignoring whitespace.
How does this PR make you feel:
If applicable: