Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some small casing issues #1561

Merged
merged 2 commits into from
Jun 14, 2021
Merged

Conversation

matthchr
Copy link
Member

  • Rename ApiVersion to APIVersion.
  • Rename GetId to GetID.

@codecov-commenter
Copy link

Codecov Report

Merging #1561 (8ae905b) into master (cc87f74) will increase coverage by 0.00%.
The diff coverage is 95.83%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1561   +/-   ##
=======================================
  Coverage   63.38%   63.38%           
=======================================
  Files         176      176           
  Lines       11669    11670    +1     
=======================================
+ Hits         7396     7397    +1     
  Misses       3609     3609           
  Partials      664      664           
Impacted Files Coverage Δ
hack/generated/pkg/genruntime/base_types.go 96.55% <ø> (ø)
...ted/pkg/reconcilers/azure_deployment_reconciler.go 59.39% <75.00%> (ø)
...ces/v1alpha1api20200601/resourcegroup_arm_types.go 100.00% <100.00%> (ø)
...sources/v1alpha1api20200601/resourcegroup_types.go 43.47% <100.00%> (ø)
hack/generator/pkg/astmodel/arm_spec_interface.go 91.39% <100.00%> (ø)
...l/armconversion/convert_to_arm_function_builder.go 87.36% <100.00%> (ø)
hack/generator/pkg/astmodel/identifier_factory.go 100.00% <100.00%> (ø)
hack/generator/pkg/astmodel/resource_type.go 71.00% <100.00%> (ø)
...g/codegen/pipeline_add_arm_conversion_interface.go 63.93% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc87f74...8ae905b. Read the comment docs.

Copy link
Member

@theunrepentantgeek theunrepentantgeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthchr matthchr merged commit a261848 into Azure:master Jun 14, 2021
@matthchr matthchr deleted the feature/little-things branch June 14, 2021 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants