Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Linux container only on Linux nodes, fixes #1560 #1563

Merged
merged 2 commits into from
Jun 14, 2021

Conversation

morsik
Copy link
Contributor

@morsik morsik commented Jun 14, 2021

Closes #1560

What this PR does / why we need it:
Allows to run ASO in Kubernetes clusters that contains also Windows nodes.

@matthchr
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2021

Codecov Report

Merging #1563 (d23cd46) into master (0e33a74) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1563   +/-   ##
=======================================
  Coverage   63.48%   63.48%           
=======================================
  Files         178      178           
  Lines       11739    11739           
=======================================
  Hits         7452     7452           
  Misses       3620     3620           
  Partials      667      667           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e33a74...d23cd46. Read the comment docs.

Copy link
Member

@matthchr matthchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthchr
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@matthchr matthchr merged commit a2d6835 into Azure:master Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Cannot install ASO in cluster that contains Windows nodes
4 participants