-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Test Package #1567
Create Test Package #1567
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
name string | ||
Imported *astmodel.PackageReferenceSet | ||
Referenced astmodel.TypeNameSet | ||
TypeReturned astmodel.Type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super minor: I have a slight preference for ReturnType here.
Oh, I see that you did this to make it consistent with Imported and Referenced. But actually present tense (Imports, References) feels more natural for those too, and I quite like that they can also be read as plural nouns as well since they're sets. 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, the function ReturnType()
is on the Function
interface, so I couldn't use ReturnType
for the member name here.
Codecov Report
@@ Coverage Diff @@
## master #1567 +/- ##
=======================================
Coverage 63.41% 63.41%
=======================================
Files 178 181 +3
Lines 11739 11793 +54
=======================================
+ Hits 7444 7479 +35
- Misses 3628 3645 +17
- Partials 667 669 +2
Continue to review full report at Codecov.
|
What this PR does / why we need it:
Eliminates most duplication of test support infrastructure, allowing reuse across multiple packages.
Doesn't eliminate all copies of
FakeFunction
as we can't move the uses withinastmodel
out without causing a package reference cycle.Special notes for your reviewer:
Will be making more reuse of methods in an upcoming PR, testing functions.
How does this PR make you feel: