-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Disk (from microsoft.compute/20200930) to generated resources #1568
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1568 +/- ##
==========================================
+ Coverage 63.41% 63.43% +0.01%
==========================================
Files 178 178
Lines 11739 11745 +6
==========================================
+ Hits 7444 7450 +6
Misses 3628 3628
Partials 667 667
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like these always look so clean!
@babbageclunk How was the experience, were there parts that were confusing/hard to understand? Did you look over the generated resource and see if it looked "reasonable"?
Pretty straightforward, nothing difficult (might have been lucky with the resource, no weird warts on this one). I did look through the resource, it seemed sane, although lots of pointers which make it a little fiddly to construct types sometimes. One thing I think would be nicer in the generated output would be to split the files up differently. At the moment the types are lost in the surrounding ARM and storage conversion functions - it might be better to have the API types in one file, then ARM types, storage types, conversion functions, maybe webhooks (although there's not that much of them at the moment) in their own files. In general the API types are what people are going to be interacting with in code, everything else is machinery that should be transparent if things are working well. |
What this PR does / why we need it:
This enables the Disk resource in code generation and adds a test that exercises creating, updating and deleting it.
Special notes for your reviewer:
The test framework is really nice now!
How does this PR make you feel:
If applicable: