Improve recorded test logging #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthchr
requested review from
babbageclunk,
davefellows,
Porges and
theunrepentantgeek
as code owners
|
Here's an example of an output with 2 failing tests: |
matthchr
force-pushed
the
feature/test-logs
branch
from
e49cbb2
to
e0b3e4d
Compare
Codecov Report
@@ Coverage Diff @@
## master #1571 +/- ##
==========================================
+ Coverage 63.41% 63.57% +0.15%
==========================================
Files 181 182 +1
Lines 11797 11856 +59
==========================================
+ Hits 7481 7537 +56
- Misses 3648 3650 +2
- Partials 668 669 +1
Continue to review full report at Codecov.
|
matthchr
force-pushed
the
feature/test-logs
branch
from
9f7461b
to
49b18f2
Compare
- It makes the output more readable if it's off
matthchr
force-pushed
the
feature/test-logs
branch
from
d30ff68
to
c7364a1
Compare
| kvListFormat(b, t.values...) | ||
| kvListFormat(b, keysAndValues...) | ||
|
|
||
| t.t.Log(fmt.Sprintf("%s \"msg\"=\"%s\" \"err\"=\"%s\"%s", header, msg, err, b)) |
There was a problem hiding this comment.
I'd like us to consider doing something smart with error logging - like breaking out messages across multiple lines so that it's possible to read errors without having to copy them out elsewhere and manually reformat them. #somethingforanothertime
There was a problem hiding this comment.
Yeah my intent with this is just to mirror as close as possible the default klog logging format, so that looking at test logs and actual "prod" logs are the same. Unfortunately because of how klog + golang testing.T are written you can't actually just plug testing.T into klog (I tried, it almost worked...)
theunrepentantgeek
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1431
What this PR does / why we need it: