Provide support for property conversions of JSON properties #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
babbageclunk,
davefellows,
matthchr and
Porges
as code owners
matthchr
approved these changes
Jun 18, 2021
| @@ -30,6 +30,7 @@ var ( | |||
| ControllerRuntimeAdmission = MakeExternalPackageReference("sigs.k8s.io/controller-runtime/pkg/webhook/admission") | |||
| GitHubErrorsReference = MakeExternalPackageReference("github.com/pkg/errors") | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Fixed by go fmt
matthchr
reviewed
Jun 18, 2021
| ) | ||
|
|
||
| type Person struct { | ||
| KnownReference genruntime.KnownResourceReference `json:"known-reference"` |
There was a problem hiding this comment.
minor: This should probably be knownReference in the JSON (even though it doesn't matter at all)
Codecov Report
@@ Coverage Diff @@
## master #1574 +/- ##
==========================================
- Coverage 63.43% 63.41% -0.03%
==========================================
Files 181 181
Lines 11796 11797 +1
==========================================
- Hits 7483 7481 -2
- Misses 3644 3648 +4
+ Partials 669 668 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We have properties of type
v1.JSONbut they were not supported by the property conversions needed for storage variants.At the same time, we generalized two existing property converters to allow support for known types to be easily added.
How does this PR make you feel:
If applicable: